Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update doc link for deprecated pipeline version removals #3317

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Update doc link for deprecated pipeline version removals #3317

merged 1 commit into from
Oct 10, 2024

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Oct 9, 2024 •
edited
Loading

JIRA: RHOAIENG-6755

Description

Update the doc link as mentioned in the JIRA.

Screenshot 2024-10-09 at 2 13 41 PM

How Has This Been Tested?

  1. Create a project and configure a pipeline server
  2. Go to the OpenShift console and edit the DSPA in the project, change spec.dspVersion from v2 to v1
  3. Go to the pipelines page, check the error message
  4. Click on the link and make sure it opens https://docs.redhat.com/en/documentation/red_hat_openshift_ai_self-managed/2.13/html/release_notes/support-removals_relnotes

Test Impact

N/A

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@codecov Codecov
Copy link

codecov bot commented Oct 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.76%. Comparing base (355fbf7) to head (34018a4).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3317   +/-   ##
=======================================
  Coverage   84.76%   84.76%           
=======================================
  Files        1309     1309           
  Lines       29318    29318           
  Branches     7981     7981           
=======================================
  Hits        24850    24850           
  Misses       4468     4468
Files with missing lines Coverage Δ
...cepts/pipelines/EnsureCompatiblePipelineServer.tsx 86.66% <100.00%> (ø)

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 355fbf7...34018a4. Read the comment docs.

Gkrumbach07
Gkrumbach07 approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 10, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c4b98db into opendatahub-io:main Oct 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gkrumbach07 Gkrumbach07 Gkrumbach07 approved these changes

@christianvogt christianvogt Awaiting requested review from christianvogt

@dpanshug dpanshug Awaiting requested review from dpanshug

Assignees

@Gkrumbach07 Gkrumbach07

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaoDaoNoCode @Gkrumbach07